Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't report expected exceptions #4

Merged
merged 5 commits into from
Nov 11, 2016
Merged

Don't report expected exceptions #4

merged 5 commits into from
Nov 11, 2016

Conversation

mattbennett
Copy link
Member

This change also reverts from using a nameko-controlled greenthread to allowing raven to use its own eventlet transport

@mattbennett mattbennett changed the title Dont report expected excs Don't report expected exceptions Nov 10, 2016
iky
iky approved these changes Nov 10, 2016
View reviewed changes
Copy link

@iky iky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice and clean .)

test_nameko_sentry.py
assert reporter._gt.dead
@pytest.fixture
def sentry_stub(self, container_factory, sentry_dsn, tracker):
""" Start a container to imitate a sentry server
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! .)

@mattbennett mattbennett merged commit 6d72c6d into master Nov 11, 2016
@mattbennett mattbennett deleted the dont-report-expected-excs branch November 11, 2016 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iky iky iky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattbennett @iky